Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing RTM_EVENTS var in docs #318

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Added missing RTM_EVENTS var in docs #318

merged 1 commit into from
Feb 17, 2017

Conversation

Roach
Copy link
Contributor

@Roach Roach commented Feb 17, 2017

PR Summary

Added missing RTM_EVENTS var in RTM send message docs

Related Issues

Fixes #317

✅ I've read and understood the Contributing guidelines
✅ I've read and agree to the Code of Conduct
✅ I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
✅ I've a descriptive title and added any useful information for the reviewer.
✅ I've read, agree to, and signed the CLA

@codecov
Copy link

codecov bot commented Feb 17, 2017 •
edited

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files          44       44           
  Lines        1194     1194           
  Branches      173      173           
=======================================
  Hits         1026     1026           
  Misses        168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc5e87...bb52343. Read the comment docs.

johnagan
johnagan approved these changes Feb 17, 2017
View reviewed changes
Copy link

@johnagan johnagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Roach Roach merged commit ac22aab into master Feb 17, 2017
@aoberoi
Copy link
Contributor

aoberoi commented Feb 17, 2017

this might be a really dumb question, but i don't see where RTM_EVENTS is being used. why are we making this change?

@Roach
Copy link
Contributor Author

Roach commented Feb 17, 2017

@aoberoi I may have mixed up this request and #319

@aoberoi
Copy link
Contributor

aoberoi commented Feb 18, 2017

@Roach cool cool. should we revert this one then? it doesn't seem like it needs to be there.

@Roach Roach mentioned this pull request Feb 23, 2017
Merged
Roach added a commit that referenced this pull request Feb 23, 2017
@Roach
Revert #318 (#322)
9990892 
* Updated RTM message receiving docs

* Revert "Added missing RTM_EVENTS var in docs"

This reverts commit bb52343.
@aoberoi aoberoi deleted the roach/rtm-docs-fix branch January 31, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnagan johnagan johnagan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Roach @aoberoi @johnagan